feat: add accessible tooltip primitive to MarketCard#422
Open
webmirroring wants to merge 1 commit into
Open
Conversation
|
@beihaiguaishou is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #365
Summary
app/components/Tooltip.tsx, a reusable accessible tooltip primitive with hover delay, keyboard focus support, Escape dismissal, touch long-press support,role="tooltip", andaria-describedbywiring only while the tooltip is rendered.MarketCardodds, pool, and ending-time metadata so those compact values have accessible explanatory text.aria-describedbyrelationship.Validation
/Users/codoon/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin/node node_modules/jest/bin/jest.js --runTestsByPath 'app/(marketing)/_components/__tests__/markets-widget.test.tsx' --runInBand/Users/codoon/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin/node node_modules/eslint/bin/eslint.js 'app/components/Tooltip.tsx' 'app/(marketing)/_components/markets-widget.tsx' 'app/(marketing)/_components/__tests__/markets-widget.test.tsx'git diff --checkExisting repo-level blockers observed
tsc --noEmitcurrently fails on unrelated existing files, including missingResolutionPreview,ErrorBoundary,shareProfile,getKit, and existingPredictionCardoutcome/categoryreferences.connect-wallet-modalmissinggetKit, event form label associations, and settings tests missingPrivacyProvider.next lintcurrently fails on unrelated existing files such asactivity-timeline-demo,EventDetailsClient,layout,PredictionCard.test.tsx, and severalreact/no-unescaped-entitiesissues. The files touched in this PR pass direct ESLint.