Modify correction extent of misleading backticks rule

Author: Kapil Borle

Rules/MisleadingBacktick.cs

@@ -55,8 +55,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                 {
                     int lineNumber = ast.Extent.StartLineNumber + i;
 
-                    var start = new ScriptPosition(fileName, lineNumber, match.Index, line);
-                    var end = new ScriptPosition(fileName, lineNumber, match.Index + match.Length, line);
+                    var start = new ScriptPosition(fileName, lineNumber, match.Index + 1, line);
+                    var end = new ScriptPosition(fileName, lineNumber, match.Index + match.Length + 1, line);
                     var extent = new ScriptExtent(start, end);
                     yield return new DiagnosticRecord(
                         string.Format(CultureInfo.CurrentCulture, Strings.MisleadingBacktickError),
@@ -75,12 +75,12 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
         /// <param name="cmdAst"></param>
         /// <returns>Returns a list of suggested corrections</returns>
         private List<CorrectionExtent> GetCorrectionExtent(IScriptExtent violationExtent)
-        {
+        {           
             var corrections = new List<CorrectionExtent>();            
             corrections.Add(new CorrectionExtent(                
-                violationExtent.StartLineNumber,
+                violationExtent.StartLineNumber ,
                 violationExtent.EndLineNumber,
-                violationExtent.StartColumnNumber,
+                violationExtent.StartColumnNumber + 1,
                 violationExtent.EndColumnNumber,
                 String.Empty,
                 violationExtent.File));

Tests/Rules/MisleadingBacktick.tests.ps1

@@ -1,19 +1,41 @@
 Import-Module PSScriptAnalyzer
 $writeHostName = "PSMisleadingBacktick"
 $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
-$violations = Invoke-ScriptAnalyzer $directory\MisleadingBacktick.ps1 | Where-Object {$_.RuleName -eq $writeHostName}
+$violationsFilepath = Join-Path $directory 'MisleadingBacktick.ps1'
+$violations = Invoke-ScriptAnalyzer $violationsFilepath | Where-Object {$_.RuleName -eq $writeHostName}
 $noViolations = Invoke-ScriptAnalyzer $directory\NoMisleadingBacktick.ps1 | Where-Object {$_.RuleName -eq $clearHostName}
 
 Describe "Avoid Misleading Backticks" {
     Context "When there are violations" {
         It "has 5 misleading backtick violations" {
+	   Import-Module .\PSScriptAnalyzerTestHelper.psm1
             $violations.Count | Should Be 5
 
-	    foreach ($violation in $violations)
-	    {
-		$violation.SuggestedCorrections.Count | Should Be 1
-		$violation.SuggestedCorrections[0].Text | Should Be ''
-	    }
+	    $idx = 0
+	    $violations[$idx].SuggestedCorrections.Count | Should Be 1
+	    $violations[$idx].SuggestedCorrections[0].Text | Should Be ''
+	    Get-ExtentText $violations[$idx].SuggestedCorrections[0] $violationsFilepath | Should BeExactly ' '
+
+	    $idx = 1
+	    $violations[$idx].SuggestedCorrections.Count | Should Be 1
+	    $violations[$idx].SuggestedCorrections[0].Text | Should Be ''
+	    Get-ExtentText $violations[$idx].SuggestedCorrections[0] $violationsFilepath | Should BeExactly ' '
+
+	    $idx = 2
+	    $violations[$idx].SuggestedCorrections.Count | Should Be 1
+	    $violations[$idx].SuggestedCorrections[0].Text | Should Be ''
+	    Get-ExtentText $violations[$idx].SuggestedCorrections[0] $violationsFilepath | Should BeExactly ' '
+
+	    $idx = 3
+	    $violations[$idx].SuggestedCorrections.Count | Should Be 1
+	    $violations[$idx].SuggestedCorrections[0].Text | Should Be ''
+	    Get-ExtentText $violations[$idx].SuggestedCorrections[0] $violationsFilepath | Should BeExactly '                     '
+
+	    $idx = 4
+	    $violations[$idx].SuggestedCorrections.Count | Should Be 1
+	    $violations[$idx].SuggestedCorrections[0].Text | Should Be ''
+	    Get-ExtentText $violations[$idx].SuggestedCorrections[0] $violationsFilepath | Should BeExactly '      '
+
         }
     }