Modify correction extent of avoid using alias

Author: Kapil Borle

Rules/AvoidAlias.cs

@@ -75,11 +75,14 @@ private List<CorrectionExtent> GetCorrectionExtent(CommandAst cmdAst, string cmd
         {
             var corrections = new List<CorrectionExtent>();
             var ext = cmdAst.Extent;
+            var alias = cmdAst.GetCommandName();
+            var startColumnNumber = ext.StartColumnNumber + ext.Text.IndexOf(alias);
+            var endColumnNumber = startColumnNumber + alias.Length;
             corrections.Add(new CorrectionExtent(                
                 ext.StartLineNumber,
                 ext.EndLineNumber,
-                ext.StartColumnNumber,
-                ext.EndColumnNumber,
+                startColumnNumber,
+                endColumnNumber,
                 cmdletName,
                 ext.File));
             return corrections;

Tests/Rules/AvoidUsingAlias.tests.ps1

@@ -2,7 +2,8 @@
 $violationMessage = "'cls' is an alias of 'Clear-Host'. Alias can introduce possible problems and make scripts hard to maintain. Please consider changing alias to its full content."
 $violationName = "PSAvoidUsingCmdletAliases"
 $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
-$violations = Invoke-ScriptAnalyzer $directory\AvoidUsingAlias.ps1 | Where-Object {$_.RuleName -eq $violationName}
+$violationsFilepath = Join-Path $directory 'AvoidUsingAlias.ps1'
+$violations = Invoke-ScriptAnalyzer $violationsFilepath | Where-Object {$_.RuleName -eq $violationName}
 $noViolations = Invoke-ScriptAnalyzer $directory\AvoidUsingAliasNoViolations.ps1 | Where-Object {$_.RuleName -eq $violationName}
 
 Describe "AvoidUsingAlias" {
@@ -16,11 +17,14 @@ Describe "AvoidUsingAlias" {
         }
 
 	It "suggests correction" {
+	   Import-Module .\PSScriptAnalyzerTestHelper.psm1
 	   $violations[0].SuggestedCorrections.Count | Should Be 1
 	   $violations[0].SuggestedCorrections.Text | Should Be 'Invoke-Expression'
+	   Get-ExtentText $violations[0].SuggestedCorrections[0] $violationsFilepath | Should Be 'iex'
 
 	   $violations[1].SuggestedCorrections.Count | Should Be 1
 	   $violations[1].SuggestedCorrections.Text | Should Be 'Clear-Host'
+	   Get-ExtentText $violations[1].SuggestedCorrections[0] $violationsFilepath | Should Be 'cls'
 	}
     }