Change SaveModule implementation

Previously, SaveModule method in ModuleDependency handler would invoke Find-Module and then Save-Module. This is inefficient as two queries are made the PSGallery server which are redundant. This commit removes Find-Module invocation.

Author: Kapil Borle

Engine/Generic/ModuleDependencyHandler.cs

@@ -239,12 +239,6 @@ public PSObject FindModule(string moduleName)
             return module;
         }
 
-
-        public bool ModuleExists(string moduleName)
-        {
-            throw new NotImplementedException();
-        }
-
         public bool TrySaveModule(string moduleName)
         {
             try
@@ -259,9 +253,6 @@ public bool TrySaveModule(string moduleName)
             }
         }
 
-        // TODO Do not use find module because it leads to two queries to the server
-        // instead use save module and check if it couldn't find the module
-        // TODO Add a TrySaveModule method
         public void SaveModule(string moduleName)
         {
             ThrowIfNull(moduleName, "moduleName");
@@ -270,16 +261,12 @@ public void SaveModule(string moduleName)
                 return;
             }
 
-            var module = FindModule(moduleName);
-            if (module == null)
-            {
-                throw new ItemNotFoundException(
-                    string.Format(
-                        "Cannot find {0} in {1} repository.",
-                        moduleName,
-                        moduleRepository));
-            }            
-            SaveModule(module);
+            var ps = System.Management.Automation.PowerShell.Create();
+            ps.Runspace = runspace;
+            ps.AddCommand("Save-Module")
+                .AddParameter("Path", tempDirPath)
+                .AddParameter("Name", moduleName);
+            ps.Invoke();
             AddModuleName(modulesSavedInTempPath, moduleName);             
         }