Add TrySaveModule method to ModuleDependencyHandler class

Author: Kapil Borle

Engine/Generic/ModuleDependencyHandler.cs

@@ -245,6 +245,20 @@ public bool ModuleExists(string moduleName)
             throw new NotImplementedException();
         }
 
+        public bool TrySaveModule(string moduleName)
+        {
+            try
+            {
+                SaveModule(moduleName);
+                return true;
+            }
+            catch
+            {
+                // log exception    to verbose
+                return false;
+            }
+        }
+
         // TODO Do not use find module because it leads to two queries to the server
         // instead use save module and check if it couldn't find the module
         // TODO Add a TrySaveModule method

Engine/ScriptAnalyzer.cs

@@ -1327,17 +1327,13 @@ private IEnumerable<DiagnosticRecord> AnalyzeFile(string filePath)
                     bool parseAgain = false;
                     if (moduleHandler != null && errors != null && errors.Length > 0)
                     {
-                        foreach (ParseError error in errors)
+                        foreach (ParseError error in errors.Where(IsModuleNotFoundError))
                         {
-                            if (IsModuleNotFoundError(error))
+                            var moduleName = ModuleDependencyHandler.GetModuleNameFromErrorExtent(error, scriptAst);
+                            if (moduleName != null
+                                && moduleHandler.TrySaveModule(moduleName))
                             {
-                                var moduleName = ModuleDependencyHandler.GetModuleNameFromErrorExtent(error, scriptAst);
-                                if (moduleName != null)
-                                {
-                                    moduleHandler.SaveModule(moduleName);
-                                    // if successfully saved
-                                    parseAgain = true;
-                                }
+                                parseAgain = true;
                             }
                         }
                     }
@@ -1364,7 +1360,6 @@ private IEnumerable<DiagnosticRecord> AnalyzeFile(string filePath)
                     {
                         string manyParseErrorMessage = String.Format(CultureInfo.CurrentCulture, Strings.ParserErrorMessage, System.IO.Path.GetFileName(filePath));
                         this.outputWriter.WriteError(new ErrorRecord(new ParseException(manyParseErrorMessage), manyParseErrorMessage, ErrorCategory.ParserError, filePath));
-
                         return new List<DiagnosticRecord>();
                     }
                 }