Merge links on nodes: Naive Gauss elimination and internal loads#1359
Open
figueroa1395 wants to merge 13 commits intomainfrom
Open
Merge links on nodes: Naive Gauss elimination and internal loads#1359figueroa1395 wants to merge 13 commits intomainfrom
figueroa1395 wants to merge 13 commits intomainfrom
Conversation
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
figueroa1395
changed the title
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
mgovers
reviewed
Apr 14, 2026
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
My comments are nitpicks. Feel free to close them or scope them out of this PR. The maths themselves as well as the order of operations seems to be good
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
mgovers
reviewed
Apr 15, 2026
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
one remaining nitpick. I believe that this is ready to merge after the clang-tidy issues have been resolved
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gauss elimination routine and the routine that computes the internal loads.
These two routines are the last in the sequece of the five steps to compute the internal load contribution of a network of short cables submitted to external loads.