functional: add value_and_grad and auxiliary value/grad args#52
Closed
Pavlo3P wants to merge 1 commit into
Closed
Conversation
Widen Functional.value/grad to accept *args/**kwargs (auxiliary parameters such as data, temperature, or a penalty weight) and add value_and_grad with a base default that delegates to value + grad, so subclasses can override with a single-pass evaluator. Extras are threaded through __call__ and the check-free cores; checked_method already forwards them and validates only x. Groundwork for the 0.4.2 optimizer-loop work (fused value_and_grad) and TraceFunctional. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Widen Functional.value/grad to accept *args/**kwargs (auxiliary parameters such as data, temperature, or a penalty weight) and add value_and_grad with a base default that delegates to value + grad, so subclasses can override with a single-pass evaluator. Extras are threaded through call and the check-free cores; checked_method already forwards them and validates only x.
Checklist
pytest tests/ -x -q)[Unreleased]