Skip to content

Fix *ToTime_t macros to work with the Arduino compiler#145

Open
tomer-w wants to merge 1 commit into
PaulStoffregen:masterfrom
tomer-w:patch-1
Open

Fix *ToTime_t macros to work with the Arduino compiler#145
tomer-w wants to merge 1 commit into
PaulStoffregen:masterfrom
tomer-w:patch-1

Conversation

@tomer-w

@tomer-w tomer-w commented Mar 1, 2020

Copy link
Copy Markdown

The daysToTime_t (and all other similar macros) does not compile correctly on recent Arduino SDK.
Apparently the compiler require that there will be no space between the macro name and the (x) parameter definition.

The daysToTime_t (and all other similar macros) does not compile correctly on recent Arduino SDK.
Apparently the compiler require that there will be no space between the macro name and the (x) parameter definition.
@46Leo

46Leo commented Oct 31, 2020

Copy link
Copy Markdown

I can confirm the issue with Arduino IDE 1.8.13 on Windows 10.
The solution for me was removing space and double parentheses, as you did in your modified header.

@jpasqua

jpasqua commented Oct 30, 2021

Copy link
Copy Markdown

Same issue with:
Arduino IDE: 1.8.13
Boards: Uno, ESP8266, ESP32
Compiler VERSION for ESP8266: 4.8.2

@tomer-w

tomer-w commented Apr 8, 2023

Copy link
Copy Markdown
Author

ping...

@murmlgrmpf

Copy link
Copy Markdown

@PaulStoffregen Thanks for the brilliant library!
Please consider to apply this pr, it is fixing the issue of the broken makros for me as well.
I am working with up to date PIO in VSC and my target is a mega2560.

@tomer-w

tomer-w commented Aug 15, 2023

Copy link
Copy Markdown
Author

@murmlgrmpf , I hate to say it, but this repository is dead. Last checkin was 2021. This is what happen with OSS when there is no continuity and people change focus without nominating people who will replace them as maintainers.

@tomer-w

tomer-w commented Aug 15, 2023

Copy link
Copy Markdown
Author

Actually, I'm taking it back. Seems @PaulStoffregen was active on github lately. Maybe he is just ignoring this repository specifically.

@tomer-w

tomer-w commented Aug 15, 2023

Copy link
Copy Markdown
Author

Actually, i'm taking it back. Seems @PaulStoffregen was active on github lately. Maybe there is a chance this will get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants