Skip to content

Add Facebreaker unique gloves support#2097

Merged
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
Anakior:facebreaker-support
Jun 5, 2026
Merged

Add Facebreaker unique gloves support#2097
LocalIdentity merged 4 commits into
PathOfBuildingCommunity:devfrom
Anakior:facebreaker-support

Conversation

@Anakior
Copy link
Copy Markdown
Contributor

@Anakior Anakior commented Jun 5, 2026

Description of the problem being solved:

Adds Facebreaker and support since i'm playing it for its three modifiers that currently show up as "Not supported in PoB yet":

  • Has 8 to 12 Physical damage, +3 to +4 per Boss's Face Broken (also the Fire variant)
  • Can Attack as though using a One Handed Mace while both of your hand slots are empty
  • Unarmed Attacks that would use an Equipped One Hand Mace's damage use this Item's damage

Steps taken to verify a working solution:

The "attack as a One Hand Mace while unarmed" bit works like Hollow Palm: when both hands are empty I set weaponData1.asThoughUsing["One Hand Mace"] in CalcSetup so mace skills become usable. The hits stay unarmed-flagged (it only satisfies the weapon requirement, it doesn't grant mace scaling). The item's base damage is added as flat unarmed damage.

The per Boss's Face Broken part is a Multiplier:BossFaceBroken driven by a new config option ("# of Boss's Faces Broken"), since that count isn't exposed by the character API and has to be entered manually like other "per X" stacks.

Also added the unique to Data + Export, regenerated ModCache, and added tests in spec/System/TestFacebreaker_spec.lua.

Screenshot

image image

@vaisest
Copy link
Copy Markdown
Contributor

vaisest commented Jun 5, 2026

The per Boss's Face Broken part is a Multiplier:BossFaceBroken driven by a new config option ("# of Boss's Faces Broken"), since that count isn't exposed by the character API and has to be entered manually like other "per X" stacks.

This is incorrect. The API does have this info in the quest field

Edit:

      "quest_stats": [
        "\u002B20 to maximum Life",
        "5% increased maximum Life",
        "5% increased maximum Mana",
        "\u002B100 to [Spirit|Spirit]",
        "\u002B5% to all [ElementalDamage|Elemental] [Resistances]",
        "\u002B15% to [Resistances|Fire Resistance]",
        "\u002B15% to [Resistances|Cold Resistance]",
        "\u002B15% to [Resistances|Lightning Resistance]",
        "30% increased Life Recovery from [Flask|Flasks]",
        "30% increased Global [Armour], [Evasion] and [EnergyShield|Energy Shield]",
        "25% increased [StunThreshold|Stun Threshold]",
        "30% increased [Charm] Charges gained",
        "\u002B1 [Charm] Slot",
        "57 [BrokenFace|Broken Boss Faces]"
      ]

@Anakior
Copy link
Copy Markdown
Contributor Author

Anakior commented Jun 5, 2026

Oh ok. I didn't saw that field, thanks a lot !

I have updated the branch to get it from this and auto fill the config but didn't removed it from the config if people want to theorycraft on it.

LocalIdentity added 2 commits June 6, 2026 02:40
Now uses the existing stat loop instead of its own
Adds a test to make sure the import from an account works properly too
The gloves are meant to become the damage source instead of granting added damage. It was incorrectly adding the base unarmed damage to attackss
Now also correctly interacts with hollow palm
Copy link
Copy Markdown
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some of the implementation so that it now works as a base damage source vs added damage
It now correctly works with hollow palm too

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jun 5, 2026
@LocalIdentity LocalIdentity merged commit eec0f7b into PathOfBuildingCommunity:dev Jun 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants