Add support for various Parry modifiers (Debuff Magnitude, Range, Duration)#2080
Open
majochem wants to merge 11 commits into
Open
Add support for various Parry modifiers (Debuff Magnitude, Range, Duration)#2080majochem wants to merge 11 commits into
majochem wants to merge 11 commits into
Conversation
Adds processing of "<DebuffName>Magnitude" modifiers, in addition to existing checks for generif "DebuffEffect" and skill-specific "Magnitude" modifiers
- Moved the process of Debuff to `skillStatMap` as "Refutation" introduced new ways to gain access to parry debuff - Changed the mod details slightly to enable better debuff processing
Parry duration hasn't been processed at all yet, and mods affecting Parry range currently false apply to the weapon range used for the Parry attack, rather than blocking distance
Makes it easier to reuse in other contexts. No functional change otherwise
Includes: - Parsing of mods - Calculation and adding to `output` - Breakdowns for each stat in CalcsSections
Also slight changes to calculation approach in `CalcPerform` as it previously didn't account for debuff effect being multiplicative
Automatically tests: - parry debuff increases damage when active - parry magnitude further increases damage - parry debuff does not affect spell damage NOTE: that last one will have to be adjusted once we support the mod that changes parry to apply to spell damage instead, but I guess that's what the test is for...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Previous implementation of the Parry Debuff was not fully supported and could not be scaled.
This PR adds support for
Steps taken to verify a working solution:
TestSkills_spec.lua(only for basic tests)Link to a build that showcases this PR:
Parry Test Build
After screenshot:
Mod Parsing
Magnitude
Duration
Range
Breakdowns
Parry Debuff from Refutation
Magnitude breakdown
Duration breakdown
Range (Non-proj) breakdown
Range (Proj) breakdown
