Update trader for 0.5 with local stat JSON and fix newlines#2020
Draft
vaisest wants to merge 6 commits into
Draft
Update trader for 0.5 with local stat JSON and fix newlines#2020vaisest wants to merge 6 commits into
vaisest wants to merge 6 commits into
Conversation
2 tasks
Wires77
reviewed
Jun 1, 2026
| _tradeStats = parsed.result | ||
|
|
||
| for _, cat in ipairs(_tradeStats) do | ||
| local file = io.open("./Data/trade_site_stats.json") |
Member
There was a problem hiding this comment.
Could we have this auto-regenerate if it's not there? As it is, when regenerating QueryMods it seems like we'd have to delete that one so it regenerates, as well as redownload this file too if I'm reading this right. Seems like it should just be one or the other, or at the very least have them both regenerate in the same way.
Contributor
Author
There was a problem hiding this comment.
Sure, I'll fix that later today by making the client download it when QueryMods is regenerated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes crash and incorrect results in trader tool resulting from the trade stat categories changing
Steps taken to verify a working solution:
This will still need an update after more mods and augments are exported.