Do not dump config for in-memory loupe setups#681
Open
Toflar wants to merge 2 commits intoPHP-CMSIG:0.12from
Open
Do not dump config for in-memory loupe setups#681Toflar wants to merge 2 commits intoPHP-CMSIG:0.12from
Toflar wants to merge 2 commits intoPHP-CMSIG:0.12from
Conversation
Member
|
@Toflar That make sense, but we should still store the configuration in memory (static PHP variable and read from it) to simulate the same behaviour as when file persistent is used. |
Member
Author
|
Erm, why? I think we definitely shouldn't. |
Member
|
@alexander-schranz keep the behaviour the same. SEAL will always use the SEAL is here a lot stricter as Loupe itself. |
Member
Author
|
Like so? |
Member
|
👍 Looks good, will test it, Lint failing seems unrelated, so you can ignore it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on some functional tests ^^