Skip to content

Do not dump config for in-memory loupe setups#681

Open
Toflar wants to merge 2 commits intoPHP-CMSIG:0.12from
Toflar:fix/in-memory-loupe
Open

Do not dump config for in-memory loupe setups#681
Toflar wants to merge 2 commits intoPHP-CMSIG:0.12from
Toflar:fix/in-memory-loupe

Conversation

@Toflar
Copy link
Copy Markdown
Member

@Toflar Toflar commented Apr 22, 2026

Noticed while working on some functional tests ^^

@alexander-schranz
Copy link
Copy Markdown
Member

@Toflar That make sense, but we should still store the configuration in memory (static PHP variable and read from it) to simulate the same behaviour as when file persistent is used.

@Toflar
Copy link
Copy Markdown
Member Author

Toflar commented Apr 27, 2026

Erm, why? I think we definitely shouldn't.

@alexander-schranz
Copy link
Copy Markdown
Member

alexander-schranz commented Apr 27, 2026

@alexander-schranz keep the behaviour the same. SEAL will always use the createIndex configuration, if configuration is changed createIndex need be called to update it. It avoids that somebody can change index configuration without explicit call create index.

SEAL is here a lot stricter as Loupe itself.

@Toflar
Copy link
Copy Markdown
Member Author

Toflar commented Apr 27, 2026

Like so?

@alexander-schranz
Copy link
Copy Markdown
Member

alexander-schranz commented Apr 27, 2026

👍 Looks good, will test it, Lint failing seems unrelated, so you can ignore it.

@alexander-schranz alexander-schranz added the bug Something isn't working label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants