Encode HTML for bundle and spec names in simple.cfm#196
Merged
Conversation
If you have HTML tags `<>` in your tests, it will break the output. This change fixes that by escaping HTML tags.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Applies HTML encoding to user/test-supplied names rendered in the simple test report to mitigate XSS risk.
Changes:
- Wrap
thisBundle.name,suiteStats.name, andthisSpec.displayNamewithencodeForHtml()when outputting in the report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have HTML tags
<>in your tests, it will break the output. This change fixes that by escaping HTML tags.Jira Issues
https://ortussolutions.atlassian.net/browse/TESTBOX-449
Type of change
Please delete options that are not relevant.