Skip to content

Refacto env vars configuration management.#4935

Merged
hurl-bot merged 1 commit intomasterfrom
refacto-env-vars
Apr 10, 2026
Merged

Refacto env vars configuration management.#4935
hurl-bot merged 1 commit intomasterfrom
refacto-env-vars

Conversation

@jcamiel
Copy link
Copy Markdown
Collaborator

@jcamiel jcamiel commented Apr 8, 2026

No description provided.

@jcamiel jcamiel force-pushed the refacto-env-vars branch 5 times, most recently from 0c128ee to 9ea2b0b Compare April 10, 2026 11:42
@jcamiel jcamiel requested a review from Copilot April 10, 2026 11:50
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors how CLI options are derived from environment variables (and aligns related CLI parsing) by extracting per-option parsing helpers and splitting color/no-color env var handling into explicit RunContext accessors.

Changes:

  • Reworked parse_env_vars into composable helper functions and rebuilt CliOptions from parsed values.
  • Split color handling into color_env_var() and no_color_env_var() with updated unit tests.
  • Simplified CLI arg parsing for follow-location and verbosity precedence.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/hurl/src/cli/options/env_vars.rs Refactors env-var parsing into helper functions and reconstructs CliOptions from computed values.
packages/hurl/src/cli/options/context.rs Introduces color_env_var / no_color_env_var, updates logic and tests accordingly.
packages/hurl/src/cli/options/args.rs Simplifies follow-location flags handling and consolidates verbosity precedence logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/hurl/src/cli/options/env_vars.rs
Comment thread packages/hurl/src/cli/options/context.rs Outdated
Comment thread packages/hurl/src/cli/options/context.rs Outdated
@jcamiel
Copy link
Copy Markdown
Collaborator Author

jcamiel commented Apr 10, 2026

/accept

@hurl-bot
Copy link
Copy Markdown
Collaborator

🕗 /accept is running, please wait for completion.

@hurl-bot
Copy link
Copy Markdown
Collaborator

✅ Pull request merged with fast forward by jcamiel..

# List of commits merged from Orange-OpenSource/hurl/refacto-env-vars branch into Orange-OpenSource/hurl/master branch:

  • f543f8d Refacto env vars configuration management.

@hurl-bot hurl-bot merged commit f543f8d into master Apr 10, 2026
25 checks passed
@hurl-bot hurl-bot deleted the refacto-env-vars branch April 10, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants