Skip to content

feat: verification confirmation email style update#139

Open
romanetar wants to merge 1 commit into
mainfrom
feature/verification-confirmation-email-update
Open

feat: verification confirmation email style update#139
romanetar wants to merge 1 commit into
mainfrom
feature/verification-confirmation-email-update

Conversation

@romanetar
Copy link
Copy Markdown
Contributor

@romanetar romanetar commented Jun 4, 2026

ref https://app.clickup.com/t/9014802374/86b9txfw9

Summary by CodeRabbit

  • New Features
    • Email verification success confirmation redesigned with clearer formatting and messaging
    • Conditional setup guidance now displays when password reset or profile completion is required
    • Added help footer with support contact information for user inquiries

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

Warning

Review limit reached

@romanetar, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 40 minutes and 35 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d09b5bb4-9c6b-4d48-bd4a-b42c53c22800

📥 Commits

Reviewing files that changed from the base of the PR and between a0eedd7 and 7a6db44.

📒 Files selected for processing (4)
  • .github/workflows/pull_request_unit_tests.yml
  • .github/workflows/push.yml
  • resources/views/emails/auth/email_verification_request_success.blade.php
  • tests/unit/EmailVerificationSuccessViewTest.php
📝 Walkthrough

Walkthrough

This PR redesigns the email verification success flow. It updates GitHub Actions workflows to configure mail sender environment variables, completely restructures the email template with table-based layout and conditional setup-completion steps, and adds comprehensive unit tests validating the template rendering across different user states and reset-password scenarios.

Changes

Email Verification Success Flow

Layer / File(s) Summary
CI environment configuration for mail sending
.github/workflows/pull_request_unit_tests.yml, .github/workflows/push.yml
Both GitHub Actions workflows add MAIL_FROM_EMAIL and MAIL_FROM_NAME environment variables set to noreply@tipit.net for mail sending during test execution.
Email verification success template redesign
resources/views/emails/auth/email_verification_request_success.blade.php
Email template is restructured from a simple centered layout to a table-based design with a "✓ You're verified" header, conditional "Two quick things to finish setup" section showing password reset (when reset_password_link exists) and profile completion (when !$user_is_complete) steps with conditional numbering, and a footer with "Questions?" prompt and help email mailto link.
Email verification success test suite
tests/unit/EmailVerificationSuccessViewTest.php
New test class validates the email template rendering with a helper to create mocked users in different completeness states. Two test cases cover scenarios with and without reset password links and with incomplete/complete user profiles, asserting subject, recipient, expected HTML fragments, and footer content. Mail is sent via real mailer to validate actual rendering.

Poem

🐰 A new email unfolds with table delight,
Steps guide users—passwords and profiles take flight,
With tests standing guard on each conditional path,
And workflows configured to send them with grace—
Email verification now matches its face!

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: the email verification template was redesigned with a new HTML table-based structure and updated visual/messaging elements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/verification-confirmation-email-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-139/

This page is automatically updated on each push to this PR.

@romanetar romanetar force-pushed the feature/verification-confirmation-email-update branch from a0eedd7 to 8d1482a Compare June 4, 2026 17:44
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-139/

This page is automatically updated on each push to this PR.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/views/emails/auth/email_verification_request_success.blade.php`:
- Around line 23-27: The intro text "Two quick things to finish setup:" is
static but the list can be one or two items; update the template logic around
the paragraph in email_verification_request_success.blade.php (near the
`@if`(!empty($reset_password_link) || !$user_is_complete) block) to render a
conditional string based on $reset_password_link and $user_is_complete — e.g.,
compute whether both steps will be shown (both $reset_password_link is not empty
AND !$user_is_complete) and use "Two quick things…" when both are true,
otherwise "One quick thing…" (or pluralize accordingly) so the sentence matches
the actual step count.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 312b3d3f-19ff-427f-a29c-9329f8043bcc

📥 Commits

Reviewing files that changed from the base of the PR and between 08712ec and a0eedd7.

📒 Files selected for processing (4)
  • .github/workflows/pull_request_unit_tests.yml
  • .github/workflows/push.yml
  • resources/views/emails/auth/email_verification_request_success.blade.php
  • tests/unit/EmailVerificationSuccessViewTest.php

Signed-off-by: romanetar <roman_ag@hotmail.com>
@romanetar romanetar force-pushed the feature/verification-confirmation-email-update branch from 8d1482a to 7a6db44 Compare June 4, 2026 17:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-139/

This page is automatically updated on each push to this PR.

@romanetar romanetar requested a review from smarcet June 4, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant