Skip to content

feat: welcome email style update#138

Open
romanetar wants to merge 1 commit into
mainfrom
feature/welcome-email-update
Open

feat: welcome email style update#138
romanetar wants to merge 1 commit into
mainfrom
feature/welcome-email-update

Conversation

@romanetar

@romanetar romanetar commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

ref https://app.clickup.com/t/86b9tx6wk

Summary by CodeRabbit

  • New Features

    • Redesigned welcome email for new users with improved layout and clearer messaging. Now displays FNid readiness confirmation and email address, with step-by-step guidance for password setup and profile completion based on user status.
  • Chores

    • Updated email configuration in CI/CD workflows.

Signed-off-by: romanetar <roman_ag@hotmail.com>
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f6cfea37-6cb0-4d41-ada8-3d8ecd8389c4

📥 Commits

Reviewing files that changed from the base of the PR and between 08712ec and 9ae95ce.

📒 Files selected for processing (4)
  • .github/workflows/pull_request_unit_tests.yml
  • .github/workflows/push.yml
  • resources/views/emails/welcome_new_user_email_fn.blade.php
  • tests/unit/WelcomeNewUserEmailFnViewTest.php

📝 Walkthrough

Walkthrough

This PR redesigns the welcome email for the FNtech identity platform with a new step-based UI layout, adds supporting environment configuration to CI workflows, and introduces a comprehensive test suite validating the new email rendering across two user scenarios.

Changes

Welcome Email Redesign

Layer / File(s) Summary
Workflow environment configuration
.github/workflows/pull_request_unit_tests.yml, .github/workflows/push.yml
Mail configuration environment variables MAIL_FROM_EMAIL and MAIL_FROM_NAME are defined for both CI workflows to enable mail functionality during test execution.
Welcome email template redesign
resources/views/emails/welcome_new_user_email_fn.blade.php
Template restructured with new centered table layout replacing previous generic branding. Header displays "Your FNid is ready" with user email in monospace. Conditional sections replaced with step-based UI: password reset step appears when reset link exists, profile completion step appears when profile incomplete, each with updated button text and step numbering logic. Footer updated to emphasize user control across tenant apps and includes mailto: link to configured help email.
Welcome email test suite
tests/unit/WelcomeNewUserEmailFnViewTest.php
New test class with test setup that fakes Queue and Mail, sets app.tenant_name to FNTECH, and provides makeUser() helper to mock User objects with conditional completeness. Two test cases validate rendering: one for incomplete user with password link (asserts presence of both steps and footer), one for complete user without password link (asserts absence of conditional steps while confirming footer content remains).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

A welcome page springs forth, fresh and new,
With steps laid clear for users to pursue,
FNid shines bright in the inbox view,
Tests verify each conditional hue,
And workflows send mail through and through! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: welcome email style update' accurately summarizes the main changes in the PR, which focus on reworking the welcome email template with a new table layout and updated copy.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/welcome-email-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

📘 OpenAPI / Swagger preview

➡️ https://OpenStackweb.github.io/openstackid/openapi/pr-138/

This page is automatically updated on each push to this PR.

@romanetar romanetar requested a review from smarcet June 4, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant