Add serialization and tests#27
Merged
Merged
Conversation
LANDAISB
requested changes
May 29, 2026
| yourself. | ||
| self test: origin on: [ :element | | ||
| self assert: element useScrollbar equals: true. | ||
| self assert: element useInfiniteLayout equals: true. |
Contributor
There was a problem hiding this comment.
Just use assert: (no need equals: true)
| ] | ||
|
|
||
| { #category : #tests } | ||
| ToSerializerTest >> testToRadioButton1 [ |
Contributor
There was a problem hiding this comment.
I think there is too much tests for only 2 parameters (1,2,3,4). You should keep only tests radioButton 2,3,4,5 (rename theme 1,2,3,4 of course)
| text := (element userData at: #placeholder) children first. | ||
| self | ||
| assert: (BlTextNonPrintableCharacterPrinter print: text text) | ||
| equals: 'Enter text...'. self assert: element useScrollbar equals: true ] |
Contributor
There was a problem hiding this comment.
Idem, no need equals: true. Just use assert:
| withRowNumbers; | ||
| yourself. | ||
| self test: origin on: [ :element | | ||
| self assert: element useScrollbar equals: true. |
LANDAISB
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests and serialization for some properties