Dev stage fixes#275
Conversation
…ove unserialized elements to 'Unstable' category
| ToAlbum. | ||
| ToTextField. | ||
| ToListElement. }. | ||
| knownNotUsable := #( #ToCircularMenuInnerElement |
There was a problem hiding this comment.
We need this list because these elements cause errors, and the test to create an element and verify if it works does not work for these elements.
| elements: (okElements sorted: [ :a :b | a name < b name ]); | ||
| yourself). | ||
| (PyramidLibraryCategory new | ||
| name: 'Unstable'; |
There was a problem hiding this comment.
Maybe 'Toplo' and 'Unstable' not good names. ''Toplo-Verified' and 'Toplo-Unverified' ?
| ^ { | ||
| (PyramidLibraryCategory new | ||
| name: 'Toplo'; | ||
| icon: (Smalltalk ui icons iconNamed: #box); |
There was a problem hiding this comment.
Another icon ? With a check ?
| ToImage. | ||
| ToAlbum. | ||
| ToTextField. | ||
| ToListElement. }. |
There was a problem hiding this comment.
ToAlbum and ToListElement are functional ?
There was a problem hiding this comment.
I added serialization methods to these elements, and the tests pass, so I think they are usable
| { #category : #accessing } | ||
| PyramidLibraryElement >> status [ | ||
|
|
||
| ^ status ifNil: [ #ok ] |
| ] | ||
|
|
||
| { #category : #accessing } | ||
| PyramidLibraryElement >> status: aSymbol [ |
There was a problem hiding this comment.
the different status should be defined on class methods (instead of calling #ok or #unstable, call PyramidLibraryElement statusUnstable). Easier to maintain.
2 participants
No description provided.