Make --address, --password-file settable from env#44
Open
peb-adr wants to merge 2 commits into
Open
Conversation
Member
Author
|
Discussed with @4echow that the code duplication introduced by me now could be reduced. Also tests should probably be written.. However we should first be sure we want this before making it very pretty. |
peb-adr
added
the
enhancement
24 tasks
peb-adr
force-pushed
the
feature/flags-from-env
branch
from
35087ff to
ebf5069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be useful if we decide to put
osmanageinto backend image.This way we can also set env vars
OSMANAGE_BACKEND_ADDRESSOSMANAGE_BACKEND_PASSWORD_FILEto container-appropriate values such that manage commands talking to backend will just work.