Skip to content

Require Qt 5.12 API#2513

Open
dg0yt wants to merge 3 commits into
OpenOrienteering:masterfrom
dg0yt:qt-updates
Open

Require Qt 5.12 API#2513
dg0yt wants to merge 3 commits into
OpenOrienteering:masterfrom
dg0yt:qt-updates

Conversation

@dg0yt

@dg0yt dg0yt commented Jun 3, 2026

Copy link
Copy Markdown
Member

No description provided.

@dl3sdo

dl3sdo commented Jun 17, 2026

Copy link
Copy Markdown
Member

I assume that workarounds for QT < 5.12 could be removed as well, e.g. in transform_t.cpp:

#if QT_VERSION == 0x050B01
// Qt 5.11.1 has a regression in QPointF::operator==.
// References:
// https://bugreports.qt.io/browse/QTBUG-69368
// https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=903237
// https://github.com/OpenOrienteering/mapper/issues/1116
#  define QTBUG_69368_QUIRK
#endif

@dg0yt

dg0yt commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

Yes, there can be more cleanup. But it can be done in different PRs.

FTR I just fixed the problem with the app not starting with Qt 5.15 for Android. There is still a glitch with the full screen mode being shifted by the size of the camera notch.

Comment thread src/gui/main_window.cpp Outdated
@dg0yt

dg0yt commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

More importantly, it is 0x050c00, not 0x051200 🤦

Fix implicit instantiation of undefined template
'QHash<QString, QtAndroid::PermissionResult>'
and 'does not provide a subscript operator'.
@dg0yt

dg0yt commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

Okay, CI here is happy, and it also build for Linux, Windows (MSVC), Android, MacOS (inc. arm64). So it can be merged with rebase soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants