Remove CSS/JS merge functionality#5021
Draft
sreichel wants to merge 5 commits intoOpenMage:mainfrom
Draft
Conversation
Hanmac
previously approved these changes
Oct 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated CSS/JS file merging functionality from OpenMage. The merge feature combined multiple CSS and JavaScript files into single files to reduce HTTP requests, but modern HTTP/2+ and asset management practices make this approach obsolete.
Key changes:
- Removed merge configuration options from system settings
- Deleted merge-related methods from core models and helpers
- Cleaned up admin UI elements related to cache flushing
- Updated localization strings to remove merge-related messages
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/locale/en_US/Mage_Core.csv | Removed translation keys for CSS/JS settings and merge options |
| app/locale/en_US/Mage_Adminhtml.csv | Removed translation keys for JS/CSS cache clearing functionality |
| app/design/adminhtml/default/default/template/system/cache/additional.phtml | Removed "Flush JavaScript/CSS Cache" button from cache management page |
| app/code/core/Mage/Page/Block/Html/Head.php | Removed merge callback logic and simplified file preparation methods |
| app/code/core/Mage/Core/etc/system.xml | Removed JavaScript and CSS settings sections from system configuration |
| app/code/core/Mage/Core/etc/config.xml | Removed default JS merge configuration |
| app/code/core/Mage/Core/Model/Design/Package.php | Removed merge URL generation methods and CSS processing callbacks, updated docblocks |
| app/code/core/Mage/Core/Helper/Data.php | Removed mergeFiles method, refactored variable names for clarity |
| app/code/core/Mage/Adminhtml/controllers/System/CacheController.php | Removed JS/CSS cache clearing logic from save action |
| app/code/core/Mage/Adminhtml/controllers/CacheController.php | Removed cleanMediaAction method |
| app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Secure.php | Deleted entire file (cleanup hook no longer needed) |
| app/code/core/Mage/Adminhtml/Model/System/Config/Backend/Baseurl.php | Removed _afterSave method that cleaned merged files |
| app/code/core/Mage/Adminhtml/Block/Cache/Additional.php | Removed getCleanMediaUrl method |
| .phpstan.dist.baseline.neon | Removed baseline entry for nullable property warning |
Comments suppressed due to low confidence (1)
app/code/core/Mage/Page/Block/Html/Head.php:123
- The third parameter passed to
_prepareStaticAndSkinElementsis now alwaysnullsince merge functionality has been removed. Consider removing the$mergeCallbackparameter entirely from the method signature to simplify the API and prevent confusion.
public function addItem($type, $name, $params = null, $if = null, $cond = null, $referenceName = '*', $before = false)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sreichel
commented
Oct 22, 2025
|
Hanmac
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description (*)
Fixed Issues (if relevant)