Skip to content

Add support for AlternativeName and better support for CustomAttribute#632

Open
ondrap wants to merge 2 commits into
OpenKMIP:masterfrom
ondrap:master
Open

Add support for AlternativeName and better support for CustomAttribute#632
ondrap wants to merge 2 commits into
OpenKMIP:masterfrom
ondrap:master

Conversation

@ondrap

@ondrap ondrap commented Aug 28, 2020

Copy link
Copy Markdown
  • it is possible to CREATE a key with these attributes
  • searching with LOCATE works for these attributes
  • as a result it seems to work with IBM tape libraries...

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 34.73054% with 109 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.97%. Comparing base (fe60ecf) to head (c8ea17d).
⚠️ Report is 72 commits behind head on master.

Files with missing lines Patch % Lines
kmip/core/attributes.py 17.64% 56 Missing ⚠️
kmip/pie/sqltypes.py 45.83% 26 Missing ⚠️
kmip/services/server/engine.py 26.92% 19 Missing ⚠️
kmip/core/factories/attribute_values.py 25.00% 6 Missing ⚠️
kmip/services/server/policy.py 86.66% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
- Coverage   96.59%   95.97%   -0.62%     
==========================================
  Files          79       79              
  Lines       16893    17058     +165     
==========================================
+ Hits        16317    16372      +55     
- Misses        576      686     +110     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants