feat: add structured logging to registration ceremony steps#246
Open
kayjoosten wants to merge 1 commit intofeature/issue-242-ceremony-step-factoryfrom
Open
Conversation
kayjoosten
force-pushed
the
feature/issue-243-registration-ceremony-logging
branch
from
b09db72 to
b482fb8
Compare
Injects LoggerInterface into SurfnetCeremonyStepManagerFactory and all custom ceremony steps. Adds a new LogRegistrationData first step that logs AAGUID, attestation format, clientDataJSON, and raw attestationObject at the start of each creation ceremony. Each custom step logs its check and result under a shared registrationId (challenge base64url) so a full registration flow is traceable by one ID. The webauthn-lib validator logger is intentionally left as NullLogger; wiring it would dump full attestation objects at info level on every request.
kayjoosten
force-pushed
the
feature/issue-243-registration-ceremony-logging
branch
from
b482fb8 to
2ec2f71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injects LoggerInterface into SurfnetCeremonyStepManagerFactory and all custom ceremony steps. Adds a new LogRegistrationData first step that logs AAGUID, attestation format, clientDataJSON, and raw attestationObject at the start of each creation ceremony.
Each custom step logs its check and result under a shared registrationId (challenge base64url) so a full registration flow is traceable by one ID.
The webauthn-lib validator logger is intentionally left as NullLogger; wiring it would dump full attestation objects at info level on every request.