Make authenticator selection criteria explicit and configurable#245
Merged
kayjoosten merged 2 commits intomainfrom May 7, 2026
Merged
Conversation
Restrict registration to cross-platform (hardware-bound) tokens by
changing authenticator_attachment from NO_PREFERENCE to cross-platform.
Expose authenticator_attachment, user_verification, and
attestation_conveyance as operator-configurable parameters in
parameters.yaml so values can be changed without touching PHP constants
.
johanib
reviewed
May 5, 2026
Contributor
johanib
left a comment
johanib
left a comment
There was a problem hiding this comment.
Looks good, some comments.
| default: | ||
| challenge_length: 64 | ||
| timeout: 30000 | ||
| user_verification: !php/const Webauthn\AuthenticatorSelectionCriteria::USER_VERIFICATION_REQUIREMENT_DISCOURAGED |
Contributor
There was a problem hiding this comment.
resident_key and user_verification are still hardcoded. Which is fine, not required for ticket 👍
…erence for new parameters
johanib
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restrict registration to cross-platform (hardware-bound) tokens by
changing authenticator_attachment from NO_PREFERENCE to cross-platform.
Expose authenticator_attachment, user_verification, and
attestation_conveyance as operator-configurable parameters in
parameters.yaml so values can be changed without touching PHP constants