Open
Conversation
kayjoosten
reviewed
Apr 23, 2026
| * The `0000-00-00 00:00:00` is added for clarity/consistency, as this is probably the default behaviour of your database already. | ||
| * Removed unused index `consent.deleted_at`. Delete this from your production database if it's there. | ||
| * Added a specific error page for unsolicited SAML responses (IdP-initiated SSO without a prior AuthnRequest). | ||
| * Added `max_issue_instant_age` to parameters.yaml to configure the logging mechanism. EB will write log entries if it receives requests that are older than this value. |
Contributor
There was a problem hiding this comment.
Very nitpick: the parameter reference isn't correct. It should be yml instead of yaml. As i said very nitpicky you dont have to change this.
kayjoosten
reviewed
Apr 23, 2026
Prior to this change, EB would not make note of the fact that old SAML requests are used. Engine does make a log notice about possible clock drift, but does so if if the time is off by 30 seconds. This change adds a warning if a request is received that is X seconds old. With the default being 1 day. Functionally, EB does proces these requests as usual, but SPs might reject the requests. Resolves #1792
johanib
force-pushed
the
feature/1792-add-expired-logging
branch
from
b917f95 to
8d30b05
Compare
kayjoosten
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, EB would not make note of the fact that old SAML requests are used. Engine does make a log notice about possible clock drift, but does so if if the time is off by 30 seconds.
This change adds a warning if a request is received that is X seconds old. With the default being 1 day.
Functionally, EB does proces these requests as usual, but SPs might reject the requests.
Resolves #1792