Skip to content

OpenConceptLab/ocl_issues#2477 | repo external exports#36

Merged
snyaggarwal merged 1 commit into
masterfrom
issues#2477
Jun 23, 2026
Merged

OpenConceptLab/ocl_issues#2477 | repo external exports#36
snyaggarwal merged 1 commit into
masterfrom
issues#2477

Conversation

@snyaggarwal

Copy link
Copy Markdown
Contributor

@paynejd paynejd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend looks good and reuses the existing ConceptContainerExport download pattern (getBlob → object-URL → anchor), so it's consistent with the codebase. One inline suggestion (pairs with the API filename change in OpenConceptLab/oclapi2#881). A few non-blocking design questions:

  • Create-only vs replace: validate() rejects a duplicate key and there's no replace affordance, so the backend's upsert/replace path (POST → 200) is unreachable from the UI. Intentional (replace is API-only), or do you want a replace action on existing exports?
  • Source vs collection UX: sources render the inline icon variant (ConceptContainerVersionList), collections render the menuItem variant (Versions.jsx). Intentional divergence?
  • Minor: getFilenameFromURL and the blob-download logic duplicate helpers already in ConceptContainerExport.jsx — worth extracting to a shared util later.

Comment thread src/components/common/RepoExternalExports.jsx
@snyaggarwal

Copy link
Copy Markdown
Contributor Author

Create-only vs replace -- not sure whats the correct path -- UI right now requires delete and add.

@snyaggarwal snyaggarwal merged commit 58e7a80 into master Jun 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add external exports support for OCL versions (upload/delete to S3-like bucket + auditable downloads)

2 participants