Skip to content

[tenable-vuln-management]: Fix crash when DomainName creation has a non-compliant value#6545

Open
Ninoxe wants to merge 2 commits into
masterfrom
bug/6325-tenable-connector-crash-on-domain-name-creation
Open

[tenable-vuln-management]: Fix crash when DomainName creation has a non-compliant value#6545
Ninoxe wants to merge 2 commits into
masterfrom
bug/6325-tenable-connector-crash-on-domain-name-creation

Conversation

@Ninoxe
Copy link
Copy Markdown
Contributor

@Ninoxe Ninoxe commented May 27, 2026

Proposed changes

  • Skip the DomainName object creation if the value is non-RFC-compliant FQDNs with a warning message

Related issues

Checklist

  • I consider the submitted work as finished
  • I have signed my commits using GPG key.
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@Ninoxe Ninoxe self-assigned this May 27, 2026
@Ninoxe Ninoxe added bug use for describing something not working as expected filigran team use to identify PR from the Filigran team connector: tenable-vuln-management labels May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (151df2a) and HEAD (6e316ad). Click for more details.

HEAD has 101 uploads less than BASE
Flag BASE (151df2a) HEAD (6e316ad)
connectors 103 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6545       +/-   ##
===========================================
- Coverage   27.96%    0.57%   -27.39%     
===========================================
  Files        1842     1782       -60     
  Lines      112094   114065     +1971     
===========================================
- Hits        31344      660    -30684     
- Misses      80750   113405    +32655     
Files with missing lines Coverage Δ
...t/src/tenable_vuln_management/converter_to_stix.py 89.58% <100.00%> (+0.45%) ⬆️

... and 986 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ncarenton ncarenton requested a review from throuxel May 28, 2026 07:38
Copy link
Copy Markdown
Member

@jabesq jabesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug use for describing something not working as expected connector: tenable-vuln-management filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tenable-vuln-management] Connector crashes on FQDN with underscore when creating STIX DomainName object

3 participants