Lots of ruff fixes

[bje-]

This is the first round of clean-ups by running ruff --select=ALL (with a few classes of warnings disabled for now).

None of these fixes have highlighted up any bugs, but they do improve readability in many instances.

[dylanjmcconnell]

.. fyi, .to_numpy is a method.. so should be .to_numpy()[0] (this is a known unsafe auto-fix)

[bje-]

Whoops!

[dylanjmcconnell]

To discuss - but I think that a) we shouldn't be using ruff --select=ALL and b) if we do want to update the ruff rules we use it should be in pyproject.toml (and capture by pre-commit)

[bje-]

To discuss - but I think that a) we shouldn't be using ruff --select=ALL and b) if we do want to update the ruff rules we use it should be in pyproject.toml (and capture by pre-commit)

There are so many useful linters in Ruff that I think the right way forward is to use --select=ALL and then selectively disable unwanted checks. I'm just proposing to go over the code once and then we can decide what linters to run via pre-commit.

[bje-]

Ping?