Bring network and resource schemas up to the newer schema format#116
Open
nick-gorman wants to merge 1 commit into
Open
Bring network and resource schemas up to the newer schema format#116nick-gorman wants to merge 1 commit into
nick-gorman wants to merge 1 commit into
Conversation
The costs, generators and storage schemas were restructured (2963704) with sectioned descriptions (Source tables / Source notes / If absent), per-column absence semantics and numeric value constraints, but the earlier network_ and resource_ schemas were left in the old flat style. This aligns them so all schemas share one format ahead of the validation layer landing. No nan_fill was added anywhere: in these tables a blank cell carries meaning (no physical limit, hard cap, static timeslice) rather than standing in for a default. resource_limits has no new-format templater yet, so its source table is inferred from the legacy REZ build-limits templater. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The costs, generators and storage schemas were restructured in #93 with sectioned descriptions (
Source tables/Source notes/If absent), per-column absence semantics and numeric value constraints, but the earliernetwork_andresource_schemas kept the old flat style. This aligns them so all schemas share one format ahead of the validation layer landing. Stacked on #109.Two choices a reviewer might query:
nan_fillanywhere. In these tables a blank cell carries meaning (no physical limit, hard cap, static timeslice) rather than standing in for a default value.resource_limitssource table is inferred. It has no new-format templater yet, soinitial_build_limitscomes from the legacy REZ build-limits templater and may need revisiting when the real one lands.The
gte: 0.0constraints are new spec, not just reformatting — nothing enforces them today, but they become real rules once validation lands.🤖 Generated with Claude Code