Skip to content

Update quality coverage condition in CI workflow#172

Open
soumeh01 wants to merge 1 commit intomainfrom
cov-run
Open

Update quality coverage condition in CI workflow#172
soumeh01 wants to merge 1 commit intomainfrom
cov-run

Conversation

@soumeh01
Copy link
Copy Markdown
Collaborator

@soumeh01 soumeh01 commented Mar 12, 2026

Changes

  • Selective run coverage
    • true for pushes and non-PR events
    • true for PRs from branches in the same repo
    • false for PRs from forks

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

## Changes
-   Selective run coverage
     - `true `for pushes and non-PR events
     - `true `for PRs from branches in the same repo
     - `false `for PRs from forks
@soumeh01 soumeh01 requested a review from JonatanAntoni March 12, 2026 10:18
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 12, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

 2 files  ±0   2 suites  ±0   0s ⏱️ ±0s
45 tests ±0  45 ✅ ±0  0 💤 ±0  0 ❌ ±0 
90 runs  ±0  90 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f55e65d. ± Comparison against base commit 52c5c93.

@JonatanAntoni
Copy link
Copy Markdown
Member

Why do we not want Coverage from outside collaborator contributions?

@soumeh01 soumeh01 requested review from brondani and jkrech March 13, 2026 08:25
@soumeh01
Copy link
Copy Markdown
Collaborator Author

soumeh01 commented Mar 17, 2026

Why do we not want Coverage from outside collaborator contributions?

GitHub treats workflows triggered by pull requests from forks as untrusted code execution. As a result of this, the secrets from the upstream are not inherited and hence don't run with upstream repo’s sensitive credentials and actions complain about the empty secret provided and fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants