Skip to content

[19.0][MIG] agreement_project: Migration to 19.0#114

Open
vvrossem wants to merge 34 commits into
OCA:19.0from
camptocamp:19.0-mig-agreement_project
Open

[19.0][MIG] agreement_project: Migration to 19.0#114
vvrossem wants to merge 34 commits into
OCA:19.0from
camptocamp:19.0-mig-agreement_project

Conversation

@vvrossem

Copy link
Copy Markdown
Contributor

No description provided.

OCA-git-bot and others added 30 commits May 27, 2026 12:21
[UPD] @murtuzasaleh remarks for readme.rst

[IMP] use search_count
Currently translated at 100.0% (7 of 7 strings)

Translation: contract-12.0/contract-12.0-agreement_project
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-agreement_project/es/
Currently translated at 100.0% (10 of 10 strings)

Translation: contract-14.0/contract-14.0-agreement_project
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement_project/es/
Currently translated at 100.0% (10 of 10 strings)

Translation: contract-14.0/contract-14.0-agreement_project
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement_project/pt_BR/
Currently translated at 100.0% (8 of 8 strings)

Translation: agreement-18.0/agreement-18.0-agreement_project
Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_project/sv/
mymage and others added 2 commits May 27, 2026 12:21
Currently translated at 100.0% (10 of 10 strings)

Translation: agreement-18.0/agreement-18.0-agreement_project
Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement_project/it/

@SilvioC2C SilvioC2C left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few improvements possible

Comment thread agreement_project/tests/test_agreement.py Outdated
Comment thread agreement_project/models/agreement.py Outdated
Comment thread agreement_project/tests/test_agreement.py Outdated

@SilvioC2C SilvioC2C left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I left another suggestion to improve tests, but it's mostly nitpicking.

Comment thread agreement_project/tests/test_agreement.py Outdated
@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.