feat(grpo): context-parallel (CP) loss alignment and reduction#66
Open
RUFFY-369 wants to merge 14 commits into
Open
feat(grpo): context-parallel (CP) loss alignment and reduction#66RUFFY-369 wants to merge 14 commits into
RUFFY-369 wants to merge 14 commits into
Conversation
…rom integration branch
…ntegration branch
…rnization baseline
- Purged AI-generated Unicode separators and ASCII decorative boxes. - Removed conversational fillers and redundant documentation artifacts. - Standardized indentation and modernized technical documentation.
…ndling.py" This reverts commit 12acffe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces Context-Parallel (CP) Loss Alignment for GRPO. It ensures that when training with sequence parallelism (CP), the GRPO loss and advantage reductions are correctly synchronized across the CP mesh workers to maintain mathematical correctness during the backward pass.
Technical Context
In a Context Parallel configuration, a single sequence is split across multiple GPUs to manage memory. Standard loss reduction often fails to account for these split segments, leading to inconsistent gradients.
This implementation introduces a specialized CP-alignment layer that:
Key Changes
Modernization & Compatibility
To support modern hardware and the latest PyTorch standards, this PR includes foundational modernization for PyTorch 2.5.1+.
Verification Results (vast.ai)