Fix Add to List automation node: write status 'active' instead of invalid 'subscribed'#377
Open
sohviktor wants to merge 1 commit into
Open
Fix Add to List automation node: write status 'active' instead of invalid 'subscribed'#377sohviktor wants to merge 1 commit into
sohviktor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Add to List automation node's config form sends
status: 'subscribed', but the backend only accepts'active'or'pending'. So the node fails at execution withinvalid status: subscribedand the contact's journey silently ends (the node showsCompleted: 0). Full details in #376.This maps the Subscribed option to the canonical backend value
'active'.Change
console/src/components/automations/config/AddToListConfigForm.tsx:STATUS_OPTIONS:{ label: t``Subscribed``, value: 'subscribed' }→value: 'active'handleStatusChangeparam type:'subscribed' | 'pending'→'active' | 'pending'config.status || 'subscribed'→config.status || 'active'This also makes the form consistent with the existing
AddToListNodeConfigtype (console/src/services/api/automation.ts), which already declaresstatus: 'active' | 'pending'.Result
Selecting Subscribed now writes
active, which passesAddToListNodeConfig.Validate()and the node completes (contact added to the list as an active subscriber).Fixes #376