Skip to content

fix: add favicon.ico support #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GulshanJha00 wants to merge 8 commits into from
Closed

fix: add favicon.ico support #476

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
72f862c
Add Gulshan to developer directory
GulshanJha00 May 3, 2026
93b871a
fix: address review feedback
GulshanJha00 May 3, 2026
2a69743
fix: prevent profile metadata from collapsing
GulshanJha00 May 3, 2026
4003542
changed width to 150px
GulshanJha00 May 3, 2026
5041b3e
Resolve merge conflict
GulshanJha00 May 3, 2026
aeed8bf
style: fix formatting
GulshanJha00 May 3, 2026
66c1bae
fix: add favicon.ico support
GulshanJha00 May 3, 2026
905b3ac
style: remove favicon cache-busting query
GulshanJha00 May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eleventy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module.exports = (eleventyConfig) => {
eleventyConfig.addShortcode("currentYear", () => new Date().getFullYear());
// Add this line to copy your external assets
eleventyConfig.addPassthroughCopy("src/assets");
eleventyConfig.addPassthroughCopy("src/favicon.ico");
// 1. Recognize YAML as a template format
eleventyConfig.addTemplateFormats("yaml");

Expand Down
Binary file added src/favicon.ico
View file
Open in desktop
Binary file not shown.
3 changes: 2 additions & 1 deletion src/index.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ layout: false
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Developer Directory</title>
<link rel="icon" type="image/x-icon" href="/favicon.ico?v=2">
Comment thread
GulshanJha00 marked this conversation as resolved.
Outdated
<link rel="stylesheet" href="/assets/css/tailwind.css">
<link rel="stylesheet" href="/assets/css/style.css">
</head>
Expand All @@ -24,7 +25,7 @@ layout: false
data-skills="{{ person.data.languages }}">
<div class="p-8">
<div class="flex justify-between items-start gap-4">
<div class="flex-1">
<div class="flex-1 min-w-[150px]">
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This layout change (min-w-[150px]) appears to be unrelated to the favicon support described in the PR title and description. To maintain code quality and follow the principle of atomic commits, unrelated changes should be handled in a separate pull request. Additionally, consider using standard Tailwind spacing classes (e.g., min-w-36 or min-w-40) instead of arbitrary values to ensure consistency with the design system.

            <div class="flex-1">
References
  1. Adhere to the project's existing CSS framework (Tailwind CSS) and its conventions, such as using standard theme values for spacing and sizing instead of arbitrary values.

<h2 class="text-2xl font-bold group-hover:text-accent transition-colors">{{ person.data.name }}</h2>
<p class="text-accent font-semibold text-sm uppercase tracking-wider">{{ person.data.role }}</p>
</div>
Expand Down