Make datasets print their code instead of <...object at 0x...>#1112
Merged
Conversation
Datasets printed as <...object at 0x...>, which made the tutorial output and the paradigm/evaluation compatibility warnings noisy to scan. Return the dataset code instead so they show up as e.g. BNCI2014-001.
Collaborator
|
This is a super cool idea! I think we can elaborate a little more on the __repr__in another PR. |
Contributor
Author
|
Thanks! Happy to keep this one minimal and focused on the readable output. I'd be glad to open a follow-up PR to elaborate on repr. Did you have something specific in mind? Happy to take a crack at it |
Collaborator
|
it is okay for now @dnplchrn, i don't have concrete proposal now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there, new here. Thanks for this project!
I was running through the tutorial examples to get familiar with moabb, and it got a bit hard for me to scan with the printed objects. Small fix: added a repr to BaseDataset that returns the dataset's code, so they show up as BNCI2014-001 instead. This also tidies up the paradigm and evaluation compatibility warnings that print during a benchmark run.
Feel free to adjust or reject this.