fix(ns.dashboard): add bytes sent/received check for ovpn connected client tunnels counter#1689
Open
m-dilorenzi wants to merge 1 commit into
Open
Conversation
…lient tunnels counter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a patch for the OpenVPN connected-client count shown on the firewall dashboard.
Previously, the dashboard API only checked whether a socket existed in the
/var/rundirectory for a specific client tunnel.If a client tunnel connected and was later disconnected, the socket could still remain in that directory, causing the dashboard to count that client as still connected.
This patch adds a check for the
bytes_receivedandbytes_sentproperties on the socket. If the client is disconnected, both values are 0.This is the same mechanism already used in the OpenVPN Tunnel section to determine whether a tunnel is connected.
Closes: #1688