Update timeout#41
Open
jayssSmm wants to merge 2 commits into
Open
Conversation
|
Test Report looks present - thanks. Reviewers will verify the captured output and idempotency evidence. |
There was a problem hiding this comment.
Thanks for your first PR to Pace — welcome aboard.
Quick orientation:
- CI runs in ~2 minutes. If anything fails, check the Actions tab — most failures have a one-line fix in
docs/troubleshooting.md. - If your PR touches
python/,ansible/, orterraform/, you'll be asked for a Test Report. It's worth the effort — reviewers rely on it. - Make sure the NetApp CCLA is on file before review.
- Stuck? Comment on this PR and a maintainer will jump in. We aim to respond as soon as possible.
For background, see CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for an optional
ONTAP_TIMEOUTenvironment variable inOntapClient.from_env().Previously,
from_env()only readONTAP_HOST,ONTAP_USER,ONTAP_PASS, andONTAP_VERIFY_SSL. This change allows users to configure request timeout through environment variables while preserving the existing default timeout behavior of 30 seconds.Also updates the README documentation to include the new environment variable.
Changes
ONTAP_TIMEOUTinOntapClient.from_env()int_DEFAULT_TIMEOUTfallback behaviorfrom_env()docstringpython/README.mdenv-var documentationChecklist
General
If touching
python/python -m py_compile python/*.py)ruff check python/)If touching
ansible/ansible-playbook --syntax-check)ansible-lintpassesIf touching
terraform/terraform fmt -checkpassesterraform validatepassesTest Report
Environment: Unreachable test host
Platform version: N/A
Style touched: python
First run
Command + output
Idempotency / re-run
Second-run evidence
Cleanup / teardown
Teardown evidence
Related issues
Fixes #35