Clarify Flower example version compatibility#4557
Conversation
Greptile SummaryThis PR fixes a real user-facing compatibility trap:
Confidence Score: 5/5Safe to merge — purely documentation and example dependency updates with no runtime code changes. All seven changed files are documentation (RST/Markdown) or example dependency manifests (pyproject.toml, requirements.txt). The version pins are internally consistent across all three dependency files, the warning text is accurate and matches the PR description, and the existing repo convention for ~=2.8.0rc pre-release specifiers is correctly applied. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User installs hello-flower] --> B{NVFlare version?}
B -->|"nvflare~=2.8.0rc (main branch)"| C["flwr>=1.26 ✓"]
B -->|"nvflare==2.7.x (released)"| D["Switch to 2.7 branch\nflwr>=1.16,<1.26 ✓"]
C --> E[NVFlare writes job-scoped\n$FLWR_HOME/config.toml\nwith dynamic SuperLink port]
D --> F["--federation-config CLI\nlegacy Flower path"]
E --> G[flwr run / list / stop\nwork correctly]
F --> H["Flower 1.26+ ignores\n--federation-config\n❌ Job aborts"]
Reviews (3): Last reviewed commit: "Merge branch 'main' into codex/flower-co..." | Re-trigger Greptile |
ad4b21e to
129e85e
Compare
|
/build |
Summary
nvflare~=2.8.0rcconvention with Flower 1.26+Why
A customer followed the main-branch hello-flower guidance with nvflare==2.7.2 and flwr==1.27.0. That released NVFlare version still uses Flower's legacy --federation-config CLI option, which Flower 1.26+ ignores, so the job aborts during flwr list/stop status checks. Main already has the Flower 1.26+ configuration-flow fix, but the public guidance was pointing users at an incompatible released version pair.
Validation