[TASK] Implement (At)RuleSet::getArrayRepresentation()#1580
Merged
Conversation
oliverklee
added
testing
oliverklee
changed the title
RuleSet::getArrayRepresentation()(At)RuleSet::getArrayRepresentation()
oliverklee
force-pushed
the
task/array-rep/ruleset
branch
from
c169f93 to
8f53b51
Compare
|
coverage: 73.324% (+0.1%) from 73.177% — task/array-rep/ruleset into main |
oliverklee
force-pushed
the
task/array-rep/ruleset
branch
from
8f53b51 to
f7e2c04
Compare
JakeQZ
requested changes
Apr 27, 2026
Collaborator
There was a problem hiding this comment.
I got a bit confused because there can be multiple values defined for a single property, e.g.
font-size: 16px;
font-size: 1rem; /* for browsers that support `rem` units */So I think the loop variable for the property value should be pluralized. Otherwise looks fine. (We already have tests for Declaration::getArrayRepresentation(), so don't need to provide property values in the tests for (At)RuleSet.)
I assume there will be a future PR to add the at-rule name to the array representation.
Co-authored-by: JakeQZ <jake.github@qzdesign.co.uk>
oliverklee
force-pushed
the
task/array-rep/ruleset
branch
from
664633c to
779d500
Compare
Collaborator
Author
I've added that now, together with the arguments. |
JakeQZ
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1440.