[codex] Add metaMetricsId feature flag overrides#8910
Draft
pedronfigueiredo wants to merge 1 commit into
Draft
Conversation
pedronfigueiredo
force-pushed
the
pnf/ff-device-override
branch
from
f7bacc1 to
9ce14c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
metaMetricsIdscoped feature flag entries to@metamask/remote-feature-flag-controller.metaMetricsIdmatches now select their associated value before threshold rollout selection.Why
Remote feature flags already support version gates and percentage rollout thresholds. This adds a targeted override path for a specific MetaMetrics user while preserving the existing threshold behavior for everyone else.
Validation
corepack yarn workspace @metamask/remote-feature-flag-controller run jest --watchman=false --no-coveragecorepack yarn workspace @metamask/remote-feature-flag-controller run buildcorepack yarn workspace @metamask/remote-feature-flag-controller run changelog:validatecorepack yarn exec eslint --pass-on-unpruned-suppressions packages/remote-feature-flag-controller/src/remote-feature-flag-controller.ts packages/remote-feature-flag-controller/src/remote-feature-flag-controller-types.ts packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.ts packages/remote-feature-flag-controller/src/index.ts packages/remote-feature-flag-controller/src/remote-feature-flag-controller.test.ts packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.test.tscorepack yarn exec oxfmt --check packages/remote-feature-flag-controller/src/remote-feature-flag-controller.ts packages/remote-feature-flag-controller/src/remote-feature-flag-controller-types.ts packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.ts packages/remote-feature-flag-controller/src/index.ts packages/remote-feature-flag-controller/src/remote-feature-flag-controller.test.ts packages/remote-feature-flag-controller/src/utils/user-segmentation-utils.test.ts packages/remote-feature-flag-controller/CHANGELOG.md