[mirror] fix(backend/notifications): atomic upsert + drop eager include

[yashwant86]

Mirror of upstream Significant-Gravitas#12919 for benchmark. Do not merge.

---

Summary by MergeMonkey

• Corrections:
  • Fixes concurrent upsert race condition where two simultaneous calls on missing batch could both attempt INSERT, losing one event. Retries on UniqueViolationError to converge on UPDATE path.
  • Eliminates eager loading of notification rows in upsert operation, preventing statement_timeout on heavy users with thousands of accumulated notifications.
• Chores:
  • Adds comprehensive async integration tests for upsert atomicity, concurrent invocations, and retry behavior.

[bot-mergemonkey]

⚡ Risk Assessment — NEEDS-TESTING · ~20 min review

Focus areas: Upsert retry logic on UniqueViolationError · Removal of eager Notifications include · Concurrent invocation safety · Unreachable RuntimeError at line 512

Assessment: Atomic upsert refactor with retry logic and eager-load removal requires integration testing.

Walkthrough

User calls create_or_add_to_user_notification_batch with a notification event. The function attempts an atomic upsert (create new batch or append to existing) without pre-fetching the batch. If two concurrent calls race on a missing row, both may attempt INSERT; the loser catches UniqueViolationError and retries, now hitting the UPDATE path. The returned DTO contains no eagerly-loaded notifications, avoiding statement_timeout on heavy users.

Changes

Files	Summary
Atomic Upsert with Retry Logic autogpt_platform/backend/backend/data/notifications.py	Replaces find-then-create-or-update pattern with atomic upsert + single retry on UniqueViolationError. Removes eager `Notifications` include to prevent statement_timeout on large batches. Handles Prisma's non-SQL-atomic upsert (find→INSERT/UPDATE) by retrying losers of concurrent INSERT races.
Upsert Integration Tests autogpt_platform/backend/backend/data/notifications_test.py	Adds four async integration tests covering empty-batch creation, append without eager load, concurrent invocations without unique violations, and deterministic retry path via monkeypatch. Includes test helpers for user/batch setup and cleanup.

Sequence Diagram

sequenceDiagram
    participant Caller
    participant NotifFunc as create_or_add_to_user_notification_batch
    participant Prisma
    participant DB as Database
    Caller->>NotifFunc: call with user_id, type, event
    NotifFunc->>NotifFunc: serialize event data
    loop attempt 0 or 1
        NotifFunc->>Prisma: upsert (no include)
        Prisma->>DB: find unique by (userId, type)
        alt row exists
            DB-->>Prisma: found
            Prisma->>DB: UPDATE + create notification
            DB-->>Prisma: updated batch
        else row missing
            DB-->>Prisma: not found
            Prisma->>DB: INSERT new batch + notification
            alt INSERT succeeds
                DB-->>Prisma: created batch
            else INSERT fails (concurrent winner)
                DB-->>Prisma: UniqueViolationError
                Prisma-->>NotifFunc: UniqueViolationError
                Note over NotifFunc: if attempt==0: continue loop
                Note over NotifFunc: if attempt==1: raise
            end
        end
        alt no exception
            Prisma-->>NotifFunc: batch (notifications=[])
            NotifFunc-->>Caller: UserNotificationBatchDTO
        end
    end

Loading

Dig Deeper With Commands

• /review <file-path> <function-optional>
• /chat <file-path> "<question>"
• /roast <file-path>

Runs only when explicitly triggered.