Skip to content

Release/2.0.1#110

Merged
antonio-olleros merged 3 commits intomainfrom
release/2.0.1
Mar 25, 2026
Merged

Release/2.0.1#110
antonio-olleros merged 3 commits intomainfrom
release/2.0.1

Conversation

@antonio-olleros
Copy link
Copy Markdown
Contributor

Description

Fix case-insensitive file extension handling in Instance.from_path(), so that files with uppercase extensions (.XBRL, .XML,
.ZIP) are processed correctly. Bump version to 2.0.1.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Dependency update
  • Other (please describe):

Related Issues

Closes #109

Changes Made

  • Normalized file suffix to lowercase in Instance.from_path() before comparing against supported extensions, consistent with the
    approach already used in the validation module.
  • Bumped version to 2.0.1 in pyproject.toml and src/xbridge/__init__.py.
  • Added changelog entry for 2.0.1.

Testing

Tests Added

  • Unit tests
  • Integration tests
  • Test coverage maintained or improved

Testing Performed

poetry run pytest tests/

Test results:
- All existing tests pass (950 passed)
- New tests pass                      
- Manual testing performed

Documentation                                                                                                                           
 
- Updated docstrings                                                                                                                    
- Updated README.md                                       
- Updated documentation in docs/
- Updated CHANGELOG.md (added entry under "Unreleased")
- No documentation needed for this change

Code Quality                                                                                                                            
 
- Code follows the project's style guidelines (Ruff)                                                                                    
- Ran ruff check and ruff format                          
- Ran mypy type checking
- Self-review of code completed
- Comments added for complex/non-obvious code
- No new warnings generated                                                                                                             
 
Breaking Changes                                                                                                                        
                                                          
N/A

Screenshots (if applicable)

N/A

Checklist

- My code follows the project's code style
- I have performed a self-review of my code
- I have commented my code, particularly in hard-to-understand areas                                                                    
- I have made corresponding changes to the documentation
- My changes generate no new warnings                                                                                                   
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes                                                                              
- Any dependent changes have been merged and published
- I have updated the CHANGELOG.md                                                                                                       
                                                          
Additional Notes

The validation module (_engine.py, _context.py) already used .suffix.lower() for extension checks. This change brings                   
Instance.from_path() in line with that pattern.
                                                                                                                                        
Reviewer Notes                                            

Areas to focus on:
- The one-line change in src/xbridge/instance.py:155
                                                    

…109)

Normalize the file suffix to lowercase before comparing against
supported extensions, so that files with uppercase extensions
(e.g. .XBRL, .ZIP) are processed correctly. This aligns with
the approach already used in the validation module.
Copy link
Copy Markdown
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😊

@antonio-olleros antonio-olleros merged commit c59335a into main Mar 25, 2026
16 checks passed
@antonio-olleros antonio-olleros deleted the release/2.0.1 branch March 25, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: case‑insensitive file extension

2 participants