Improves UpDown text input clamping behavior#4064
Merged
Merged
Conversation
fix: Prevent NumericUpDown from resetting text input during typing ``` ``` Introduces a flag to temporarily disable the text box's value update while the user is actively typing. This prevents the control from prematurely overwriting partial user input, which previously made it difficult to enter values when a minimum or maximum was set. Resolves #4061 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue in the
NumericUpDowncontrol where, during user input, a partially typed number that temporarily fell outside theMinimumorMaximumrange would cause the control to immediately clamp the value. This clamped value would then overwrite the user's ongoing input in the textbox, making it difficult to complete the desired number.Introduces an
_isTextChangingflag to prevent the textbox from being programmatically updated when theValuechanges as a direct result of user input in the textbox. This ensures that the user's input remains undisturbed during typing, allowing them to complete their intended value without premature overwrites.A new UI test validates this improved behavior, confirming that the control now correctly handles typing sequences.
Fixes #4061