feat(alerts): merge signal + checks charts into one "Signal & evaluations" view#154
Merged
Merged
Conversation
…ions" view The alert rule detail page drew the same metric twice across two tabs: the Overview area chart (continuous warehouse signal, which turned into an unreadable "glittery" mush of overlapping translucent areas when grouped by service) and the Checks sparkline (the engine's discrete evaluations). Same metric, same threshold, same window — they read as duplicates even though the underlying sources differ (raw signal vs. the engine's decisions). Replace both with a single AlertSignalChart that stacks the two layers on one shared time axis and one threshold: - Signal layer: single series renders an area with a comparator-aware threshold-split fill (destructive above the line for gt/gte, below for lt/lte); multi-series renders thin lines with no fill — killing the glitter. - Decision layer: a thin per-bucket "evaluation rail" of status cells (breached / healthy / skipped), reusing the page's existing timeline-strip idiom, with a legend. - Incident windows shaded across both via ReferenceArea. - raw_query rules, which previously showed "preview unavailable", now render a checks-driven chart + rail. Also fold the checks stat strip + audit table into Overview and drop the separate Checks tab (rule detail is now Overview + History). The redundant CheckHistorySparkline component is deleted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Your LLM provider API key was rejected. Rotate the key in your provider dashboard, then update the matching GitHub Actions secret. Update repo secret → · Model settings → · Setup docs → · Ask in Discord →
|
Folding the Checks tab into Overview dropped the checksResult error branch, so a failed checks query silently resolved to [] and ChecksPanel rendered the misleading "No checks in this window" empty state with no way to retry. Restore the error UI (Failed to load checks + Retry) by wrapping the ChecksPanel render in Result.builder(checksResult).onError(...), and re-add the refreshChecks atom refresh that powers the retry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The X-axis is explicitly drawn over [domain.min, domain.max], so the adaptive tick-label decision (include date / seconds) should follow the axis width the ticks actually cover, not the data range. Derive axisContext.rangeMs from the domain; keep bucketSeconds data-derived for tick granularity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
Replaces the two separate, duplicate-looking charts on the alert rule detail page with a single merged AlertSignalChart.
Before, the same metric was drawn twice across two tabs:
Same metric, same threshold, same window, so it read as a duplicate — even though the two sources are genuinely different (raw signal vs. the engine's decisions).
How
One chart, two layers on a shared time axis + one threshold:
--destructiveabove the line forgt/gte, below forlt/lte, so the fill encodes the breach region); multi-series → thin lines with no fill, which removes the glitter.ReferenceArea(matching the existinganomaly-timeseries-chart.tsxpattern).raw_queryrules — previously showed "preview unavailable"; now render a checks-driven chart + rail.Per the agreed scope, the checks stat strip + audit table move into Overview and the separate Checks tab is removed (rule detail is now Overview + History). The now-redundant
CheckHistorySparklineis deleted.No new data fetching —
chartData,checks,ruleIncidents, and the page time window were all already in scope on the detail page.Files
apps/web/src/components/alerts/alert-signal-chart.tsxapps/web/src/routes/alerts/$ruleId.tsxapps/web/src/components/alerts/check-history-sparkline.tsxVerification
bun typecheckclean across all packages.raw_querychecks-driven fallback, andlt/apdex breach-below fill — all correct, no console errors.Reviewer notes
AlertPreviewChartis intentionally kept — it's still used by the create-form live hero (rule-live-chart-hero.tsx), which has no checks/incidents yet.scale="time") X-axis so checks/incidents place by real time; warehouse bucket strings and check timestamps are both normalized to UTC ms vianormalizeTimestampInput.🤖 Generated with Claude Code