Update digital_rf_hdf5.py to allow reading 1 sample using DigitalRFReader.read_vector_raw#115
Closed
Sponge166 wants to merge 2 commits into
Closed
Update digital_rf_hdf5.py to allow reading 1 sample using DigitalRFReader.read_vector_raw#115Sponge166 wants to merge 2 commits into
Sponge166 wants to merge 2 commits into
Conversation
read_vector_raw would error if vector_length==1 and only one subchannel is read from, due to z.squeeze() returning a scalar when z contains one sample.
Member
|
Thanks for noticing the bug and thanks for the PR! I'm partial to using |
Contributor
Author
|
oh oops lol, didn't know that would happen |
Member
|
It's alright, I can merge from my local copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_vector_raw would error if vector_length==1 and only one subchannel is read from, due to z.squeeze() returning a scalar when z contains one sample.