Fix synthetic filter interpolation outside passbands#1032
Open
nialljmiller wants to merge 2 commits into
Open
Conversation
Member
|
Nice find! I can't look at my computer for another couple days because im moving apts, just an fyi! But this is awesome! Is there a reason the bolometric flux tests didn't capture this in the unit tests, maybe because i used too low log G and low teff? Do we need a high logG hot Teff bb flux unit test added to the others, so this would be caught? Is there a particular place where this comes? Perhaps we add a minor changelog entry for this to mark it and tweak the unit tests slightly to capture this scenario? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes synthetic photometry for filters interpolated onto SED wavelength grids.
Previously, interpolated filter transmission could remain nonzero outside the tabulated filter wavelength range.
This produced out-of-band flux leakage for hot/blue SEDs, especially WD and blackbody models, causing unphysical synthetic colors. I found this testing WD cooling tracks.
The fix clamps interpolated filter transmission to zero outside the original filter support and clips negative interpolated transmission values to zero.
Here is the function that has been added to
colors/private/synthetic.f90--