fix_uninitialized RSP L on photo restart, bug found by Mami Dekka#1031
Open
Debraheem wants to merge 1 commit into
Open
fix_uninitialized RSP L on photo restart, bug found by Mami Dekka#1031Debraheem wants to merge 1 commit into
Debraheem wants to merge 1 commit into
Conversation
Member
Author
|
One might ask why we don't just store and read L when the rsp flag is set. That might be a good idea as well, although it would not be providing the photos any new information they don't already have. I can think of other fixes as well, like raising the floor on L for Kh_timescale to a large positive number instead of 0d0. But L could still then be undefined upon photo restart. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mami-deka discovered an issue in RSP's photo restart where on one of her clusters, L was being set to a small positive number, since it was uninitialized, and this lead to the call to calculate the KH_timescale (which asks for it asks for s% L(1), and divides by it) to produce a large infinite number from overflow, ultimately crashing her mesa run.
from @mami-deka:
She also discovered the solution to this issue, which was to recalculate L upon restart.