WIP: Update to GHC 9 + Add -Wall -Werror#160
Draft
augyg wants to merge 4 commits into
Draft
Conversation
- Add -optcxx-DOPENCV4 to cabal ghc-options so the OPENCV4 define reaches the C++ compiler (GHC 9.10 splits -optc/-optcxx) - Guard getAffineTransform against collinear source points, returning a CvException instead of silently producing a garbage matrix - Bound rect QuickCheck generators to avoid Int32 overflow in OpenCV 4's Rect::area() assertion - Add shell.nix for local development with callCabal2nix
- Generate non-degenerate triangles instead of arbitrary points - Restore Left as test failure for the happy-path property - Add explicit test that collinear points return an error
- Replace all kind-level * with Type from Data.Kind across 25+ files - Remove redundant Data.Monoid (<>) imports (in Prelude since base 4.9) - Remove redundant Data.Foldable/Data.Traversable imports - Suppress -Wtype-defaults in inline-c generated StructuralAnalysis code
- Fix incomplete pattern matches in Juicy.hs Storable instances - Fix partial head usage in Core/Types/Mat.hs and test.hs - Guard estimateRigidTransform with #ifndef OPENCV4 (removed in OpenCV 4) - Guard OpenCV.Video re-export in OpenCV.hs Library and tests now build clean with -Wall -Werror.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.