Extract TargetedMSHelper and add upgrade test for 26.3 schema migration#1211
Open
labkey-jeckels wants to merge 4 commits into
Open
Extract TargetedMSHelper and add upgrade test for 26.3 schema migration#1211labkey-jeckels wants to merge 4 commits into
labkey-jeckels wants to merge 4 commits into
Conversation
Extracts setupFolder(), selectFolderType(), and importData() from TargetedMSTest into a new TargetedMSHelper class so the logic can be shared without subclassing. Adds TargetedMSUpgradeTest to verify the targetedms-26.006-26.007 migration correctly populates PeptideGroupCount, MoleculeGroupCount, and ProteinCount on existing runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
ERROR: A pull request from |
labkey-jeckels
changed the base branch from
release26.3-SNAPSHOT
to
release25.11-SNAPSHOT
labkey-tchad
approved these changes
May 18, 2026
testPreUpgradeCounts queries columns available in 25.11 (Peptides, SmallMolecules,
Replicates) and runs on both setup and verify phases. testPostUpgradeCounts is
gated with @EarliestVersion("26.3") and Assume.assumeFalse(isUpgradeSetupPhase)
so it only runs on the new server after the 26.006-26.007 migration.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Create the first upgrade test for the TargetedMS module.
Changes