Issue 1135: More changes for accessibility#2004
Open
labkey-susanh wants to merge 45 commits into
Open
Conversation
…ut fields in detail editing forms
This was referenced May 20, 2026
cnathe
approved these changes
May 22, 2026
|
|
||
| if (!showLabel) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
minor: looks like the <FieldLabel> component does this in its render() method. Was this needed for another reason?
| return ( | ||
| <FormsyTextArea | ||
| id={queryColumn.fieldKey} | ||
| aria-label={showLabel ? undefined : queryColumn.caption} |
Contributor
There was a problem hiding this comment.
minor: this is probably sufficient for aria-label but the renderLabel uses conditional logic to either use the label prop or the query column. Do we need that here?
|
|
||
| if (!showLabel) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
minor: same comment here about FieldLabel already doing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1135: Additional accessibility improvements mostly for field labels with a few tabIndex adjustments and elements becoming buttons.
Related Pull Requests
Changes
DomainRowlabelIdgetter method inQueryColumn